-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Stack Overflow for Debug::fmt
#630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
+ Coverage 72.56% 72.62% +0.06%
==========================================
Files 179 179
Lines 13259 13279 +20
==========================================
+ Hits 9621 9644 +23
+ Misses 3638 3635 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how this was done :)
I added some comments, mostly to add a bit of documentation and to maybe improve the debug output if you agree.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready! I just found one undocumented static.
Windows check failed with no logs, not sure if I can rerun it? |
That is strange. Ill rerun it :) |
This Pull Request fixes/closes #608.
It changes the following:
GcObject
pointers that have been visited during aDebug::fmt
call.The same object cannot appear twice in the output, by design. JS object graphs tend the be huge, and comprehending a massive data dump is nearly impossible. If the same object appears twice, even if not recursive, it is always elided. The following graph:
Would print: